[Storage-Preview] az storage account task-assignment: Storage Task-Assignment GA for Storage-Actions#8909
Conversation
…ureCloud --endpoint-resource-manager https://eastus2.management.azure.com/`
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| storage account create | cmd storage account create update parameter sku: updated property choices from ['Premium_LRS', 'Premium_ZRS', 'Standard_GRS', 'Standard_GZRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_RAGZRS', 'Standard_ZRS'] to ['PremiumV2_LRS', 'PremiumV2_ZRS', 'Premium_LRS', 'Premium_ZRS', 'StandardV2_GRS', 'StandardV2_GZRS', 'StandardV2_LRS', 'StandardV2_ZRS', 'Standard_GRS', 'Standard_GZRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_RAGZRS', 'Standard_ZRS'] |
||
| storage account update | cmd storage account update update parameter sku: updated property choices from ['Premium_LRS', 'Premium_ZRS', 'Standard_GRS', 'Standard_GZRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_RAGZRS', 'Standard_ZRS'] to ['PremiumV2_LRS', 'PremiumV2_ZRS', 'Premium_LRS', 'Premium_ZRS', 'StandardV2_GRS', 'StandardV2_GZRS', 'StandardV2_LRS', 'StandardV2_ZRS', 'Standard_GRS', 'Standard_GZRS', 'Standard_LRS', 'Standard_RAGRS', 'Standard_RAGZRS', 'Standard_ZRS'] |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull Request Overview
This pull request upgrades the vendored Azure Storage Management SDK from version "2023-05-01" to "2024-01-01". Key changes include updating all API version strings, revising type annotations (for example, changing maxpagesize from Optional[str] to Optional[int]) and removing redundant _convert_request calls.
Reviewed Changes
Copilot reviewed 59 out of 107 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| _storage_task_assignments_instances_report_operations.py | Updated API version and removed _convert_request calls in prepare_request. |
| _storage_task_assignment_instances_report_operations.py | Updated API version documentation and parameter types. |
| _storage_accounts_operations.py | Updated API version strings, adjusted return type annotations, and removed _convert_request calls. |
| _skus_operations.py | Updated API version and type imports. |
| _queue_services_operations.py | Revised API version and removed extra _convert_request calls. |
| _queue_operations.py | Updated API versions and removed redundant conversion calls. |
| _private_link_resources_operations.py | Updated API version and removed _convert_request call. |
| _private_endpoint_connections_operations.py | Updated API versions and removed extra _convert_request calls. |
| _operations.py | Revised API version strings and removed _convert_request calls. |
| _object_replication_policies_operations.py | Updated API version, types and removed redundant conversion calls. |
| _network_security_perimeter_configurations_operations.py | Updated API version, added streaming error handling, and removed _convert_request calls. |
| _management_policies_operations.py | Updated API version and revised docstrings and type annotations. |
| _local_users_operations.py | Updated API version, types and removed _convert_request calls. |
| _file_shares_operations.py | Updated API version and removed redundant _convert_request calls in request preparation. |
| _file_services_operations.py | Updated API version, added new methods for listing service usages, and removed _convert_request calls. |
Comments suppressed due to low confidence (1)
src/storage-preview/azext_storage_preview/vendored_sdks/azure_mgmt_storage/v2024_01_01/aio/operations/_storage_task_assignments_instances_report_operations.py:117
- Please confirm that the removal of the _convert_request() call is intentional and does not affect the request formatting or downstream processing.
)
|
[Release] Update index.json for extension [ storage-preview-1.0.0b6 ] : https://dev.azure.com/msazure/One/_build/results?buildId=128805173&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Azure/aaz#797
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.